Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decompositions of parameterized cirq.CCZPowGate #5087

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Add support for decompositions of parameterized cirq.CCZPowGate #5087

merged 4 commits into from
Mar 17, 2022

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners March 16, 2022 22:57
@tanujkhattar tanujkhattar requested a review from mpharrigan March 16, 2022 22:57
@CirqBot CirqBot added the Size: XS <10 lines changed label Mar 16, 2022
@tanujkhattar tanujkhattar changed the title Add support for decompositions of parameterized cirq.DiagonalGate Add support for decompositions of parameterized cirq.CCZPowGate Mar 16, 2022
@tanujkhattar tanujkhattar changed the title Add support for decompositions of parameterized cirq.CCZPowGate Add support for decompositions of parameterized cirq.CCZPowGate Mar 16, 2022
@tanujkhattar tanujkhattar added the priority/high This is something that should get done soon, e.g. within a month. label Mar 16, 2022
MichaelBroughton
MichaelBroughton approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a test here ?

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 17, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 17, 2022
@tanujkhattar
Copy link
Collaborator Author

@MichaelBroughton Added a test. Merging now.

@tanujkhattar tanujkhattar merged commit 66dd508 into quantumlib:master Mar 17, 2022
@tanujkhattar tanujkhattar deleted the three_qubit_decomposition branch March 17, 2022 01:55
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add support for decompositions of parameterized cirq.CCZPowGate (qu…
d308676 
…antumlib#5087)

* Add support for decompositions of parameterized cirq.CCZPowGate

* Add test for parameterized decomposition of CCZ
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Add support for decompositions of parameterized cirq.CCZPowGate (qu…
a5ae2c5 
…antumlib#5087)

* Add support for decompositions of parameterized cirq.CCZPowGate

* Add test for parameterized decomposition of CCZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. priority/high This is something that should get done soon, e.g. within a month. Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanujkhattar @MichaelBroughton @CirqBot